Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] l10n_jp_partner_title_qweb #28

Merged
merged 10 commits into from
Dec 28, 2022

Conversation

yostashiro
Copy link
Sponsor Member

Standard migration.

yostashiro and others added 9 commits August 7, 2022 08:35
* [ADD] l10n_jp_partner_title_qweb

* minor adjustments

* remove blank line

* [FIX] wrong object reference

* remove onchu translation

* [IMP] add constraint

* show title field

* [FIX] version

* add tests

* [FIX] enable japanese
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-japan-12.0/l10n-japan-12.0-l10n_jp_partner_title_qweb
Translate-URL: https://translation.odoo-community.org/projects/l10n-japan-12-0/l10n-japan-12-0-l10n_jp_partner_title_qweb/
Remove the tile proposal logic of res.partner to avoid the complexity - in some cases
an 'individual' partner in Odoo could be an organization, etc., and we conclude that
we should not have a rigid proposal logic in this module.
@yostashiro
Copy link
Sponsor Member Author

@kakurai8 Please review this one instead.

@yostashiro yostashiro force-pushed the 15.0-mig-l10n_jp_partner_title_qweb2 branch from 5796ace to 020f878 Compare October 9, 2022 14:01
@yostashiro
Copy link
Sponsor Member Author

/ocabot migration l10n_jp_partner_title_qweb

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 8, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 8, 2022
2 tasks
Copy link

@kakurai8 kakurai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it works as expected.

  • set Contacts > Configuration > Contact Titles
  • update Contacts>Title
  • print Title is visible expected

Copy link

@kakurai8 kakurai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it works as expected.

  • set Contacts > Configuration > Contact Titles
  • update Contacts>Title
  • print Title is visible expected

Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review and tested in local environment. It worked as expected.

@yostashiro
Copy link
Sponsor Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-28-by-yostashiro-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e5af6a2 into OCA:15.0 Dec 28, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c4babc0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants